Added Node Degree Filter#2615
Open
DanielLacina wants to merge 23 commits into
Open
Conversation
ljeub-pometry
requested changes
May 26, 2026
Collaborator
ljeub-pometry
left a comment
ljeub-pometry
left a comment
There was a problem hiding this comment.
- make the public api consistent
- shouldn't comment out the gql apis
| "raphtory-storage", | ||
| "raphtory-api-macros", | ||
| "raphtory-itertools", | ||
| "clam-core", |
Collaborator
There was a problem hiding this comment.
you need to put these back
shivamka1
requested changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I added a Node Degree Filter that can be passed into graph.filter to filter nodes based on if their degrees follow the filter expr represented by the Node Degree Filter. Filter expression include: ge, le, ne, lt, gt, is_in, not_is_in. If any other expression is called, the code panics.
Why are the changes needed?
The whole filtering module is used to provide a more user friendly Python interface when it comes to filtering. We would like to make filtering based on degrees user friendly so that's why I added this feature.
Does this PR introduce any user-facing change? If yes is this documented?
Yes. It is not documented.
How was this patch tested?
Through prop tests and Python tests
Are there any further changes required?
We will definitely need to refactor the Rust filtering module because it's too coupled to certain operations such as property filtering which fails to generalize and make the code reusable ultimately leading to repeated and inflexible code.