fix(client): require 3 minute GTD expirations#134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
uv run pytest tests/unit/test_order_limit.pyuv run ruff check .uv run ruff format --check .uv run pyrightuv run pytest -m "not integration"Note
Medium Risk
Tightens trading input validation and may break integrations that relied on 60–179 second GTD expirations; behavior change is localized to limit orders with an explicit expiration.
Overview
Raises the minimum future expiration for GTD limit orders from 60 seconds to 3 minutes (180s) in
validate_limit_order_paramsvia_MIN_EXPIRATION_BUFFER_S.Sync and async secure client docs for
create_limit_order/place_limit_ordernow describe the 3-minute rule. Unit tests were updated for rejection messages and the 180s acceptance boundary.Note: Callers passing
expirationbetween ~60s and ~179s ahead oftime.time()will now getUserInputErrorbefore sign/post.Reviewed by Cursor Bugbot for commit 0c113cd. Bugbot is set up for automated code reviews on this repo. Configure here.