fix(hud): apply text styles to potion effects - #168
Open
anolithme wants to merge 1 commit into
Open
Conversation
Contributor
|
Hmm in my 1.8.9 version I had this setup individually for both effect name and duration. I feel it would be better to have this applied to global and per effect/effect-type rules In addition how does this fair against resource packs that could use formatting codes or even reset the formatting codes on the effect name? |
Contributor
|
It's probably better to use components rather than legacy formatting codes, that way e.g. a resource pack resetting formatting would just reset it to the style we set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bold and italic didn't work on potion effect text when using the Minecraft font. this fixes both and keeps italic text aligned with the icons.
Related Issue(s)
None
How to test
use the Minecraft font in the Potion Effects HUD and toggle bold and italic. check that both styles work and the text doesn't overlap the icons
visually tested on 26.2
automated tests pass on all supported versions
Release Notes
Documentation
No documentation changes.