Fix critical regressions and performance issues - #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some critical regressions as a result of 1.2.0 which were resulting in the language server being broken in some codebases. It also significantly improves performance as a whole.
Greptile Summary
The PR addresses language-server regressions while restructuring incremental analysis and request freshness behavior to reduce editor latency.
Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Document change] --> B[Apply text update] B --> C[Debounced self-index] C --> D[Unblock requests for edited document] D --> E[Completion, hover, and document diagnostics] C --> F[Accumulate dependency expansion] F --> G{Typing quiet or deferral cap reached?} G -- No --> B G -- Yes --> H[Run dependency ripple] H --> I[Invalidate shared diagnostic cache] I --> J[Refresh supported semantic and inlay features] I --> K[Schedule idle workspace diagnostic refresh]Reviews (3): Last reviewed commit: "perf: highlight the edited file without ..." | Re-trigger Greptile