Fix various issues and add missing VGUI panels - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Greptile Summary
The PR improves generated LuaLS annotations and adds missing metadata for several VGUI and Garry's Mod classes.
Confidence Score: 5/5
The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified.
The changed writer behavior is covered for its intended table, union, enum, and default-annotation cases, while the observed complicated nested-union limitation is already explicitly documented as unsupported.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Wiki type and struct metadata] --> B[GluaApiWriter] B --> C[Transform union members] C --> D[Convert sequential tables] B --> E[Normalize field defaults] D --> F[Generated LuaLS annotations] E --> F G[Custom VGUI metadata] --> FReviews (1): Last reviewed commit: "Fix custom overrides to use proper annot..." | Re-trigger Greptile