Skip to content

Switch to new enums instead of alias - #18

Merged
Pollux12 merged 1 commit into
betafrom
feat/enum-refactor
Aug 18, 2026
Merged

Switch to new enums instead of alias#18
Pollux12 merged 1 commit into
betafrom
feat/enum-refactor

Conversation

@Pollux12

@Pollux12 Pollux12 commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Greptile Summary

The PR replaces alias-based annotations for global enumerations with flat numeric enum declarations so completion can suggest global constant names.

  • Emits ---@enum NAME : number and lists each numeric member by its global identifier.
  • Includes available member descriptions while omitting descriptions that are empty.
  • Updates writer tests to assert the new enum representation and continued exclusion of nonnumeric TODO values.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failure identified.

The implementation and tests consistently switch global enum output from numeric aliases to named flat enums while preserving the existing numeric-member filtering and an explicit numeric base.

Important Files Changed

Filename Overview
src/api-writer/glua-api-writer.ts Replaces global numeric aliases with flat enum annotations while retaining numeric filtering and number-base assignability.
tests/api-writer/glua-api-writer.spec.ts Updates global-enum expectations to cover named members, optional descriptions, TODO filtering, and removal of the old alias.

Reviews (1): Last reviewed commit: "Add support for global flat enums" | Re-trigger Greptile

@Pollux12
Pollux12 merged commit a3befb0 into beta Aug 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant