Weight US fiscal calibration loss by target value#89
Merged
Conversation
a0de159 to
adb25bd
Compare
adb25bd to
cb6a206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The broken release exposed that an unweighted row average is not a sufficient solve priority for a target surface dominated by many state-level rows. Hard gates now prevent critical misses from certifying; this PR changes the optimizer objective so large national fiscal targets receive proportionate pull during the solve.
Validation
PYTHONPATH=packages/populace-calibrate/src:packages/populace-frame/src uv run --python 3.13 --with pytest --with numpy --with pandas --with torch --with scipy python -m pytest packages/populace-calibrate/tests/test_solve.py -qPYTHONPATH=packages/populace-build/src:packages/populace-calibrate/src:packages/populace-frame/src:packages/populace-fit/src:packages/populace-data/src uv run --python 3.13 --with pytest --with numpy --with pandas --with packaging --with h5py --with torch --with scipy python -m pytest packages/populace-build/tests/test_gates.py packages/populace-build/tests/test_us_fiscal_refresh_builder.py -quv run --python 3.13 ruff check packages/populace-calibrate/src/populace/calibrate/solve.py packages/populace-calibrate/tests/test_solve.py packages/populace-build/tests/test_gates.py tools/build_us_fiscal_refresh_release.py packages/populace-build/tests/test_us_fiscal_refresh_builder.pyuv run --python 3.13 ruff format --check packages/populace-calibrate/src/populace/calibrate/solve.py packages/populace-calibrate/tests/test_solve.py packages/populace-build/tests/test_gates.py tools/build_us_fiscal_refresh_release.py packages/populace-build/tests/test_us_fiscal_refresh_builder.py && git diff --check