Add bus_fare_spending input variable#1780
Merged
Merged
Conversation
Companion to the LCFS bus fare imputation in policyengine-uk-data (#428). Household-level COICOP 7.3.2 (bus & coach fares), mirroring petrol_spending/ diesel_spending. CPI-uprated; not added into the consumption total, which already counts bus fares via transport_consumption. Provides the passenger fare households pay (vs the ETB-based bus_subsidy_spending) for modelling bus fare reforms. Resolves #1779. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
I found one integration issue in the first pass: I pushed uv run pytest policyengine_uk/tests/test_road_fuel_volume_uprating.py policyengine_uk/tests/test_no_economic_assumptions.pyResult: 4 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Household input variable
bus_fare_spending(COICOP 7.3.2 — bus & coach fares), the companion to the LCFS bus fare imputation in PolicyEngine/policyengine-uk-data#428.Why
The data PR writes a
bus_fare_spendingcolumn, but without a registered variable the model silently skips it on load (simulation.pyignores unknown columns). This variable lets the model consume it.bus_fare_spendingis the passenger fare households pay, distinct frombus_subsidy_spending(the ETB government-subsidy benefit-in-kind) — the building block for modelling bus fare reforms (£2 cap, free travel for young people), as the bus analogue of the existing rail fare modelling.Details
petrol_spending/diesel_spending, which are likewise COICOP sub-components oftransport_consumption.gov.economic_assumptions.indices.obr.consumer_price_index), matchingtransport_consumptionand the data-side uprating.consumptiontotal —transport_consumptionalready includes bus fares, so adding it would double-count.Verified: registers in the tax-benefit system and the uprating parameter resolves.
Resolves #1779. Companion to PolicyEngine/policyengine-uk-data#428 (tracked in PolicyEngine/policyengine-uk-data#427).
🤖 Generated with Claude Code