Skip to content

fix: set character limit in schemas as DB limit (25 instead of 20) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toto04 merged 2 commits into from
Apr 23, 2026
Merged

fix: set character limit in schemas as DB limit (25 instead of 20) #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3827fe
fix: set character limit in schemas as DB limit (25 instead of 20)
toto04 Mar 30, 2026
99298c3
fix: typo
toto04 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@
"tw-animate-css": "^1.3.8",
"typescript": "^5"
},
"packageManager": "pnpm@10.18.1+sha512.77a884a165cbba2d8d1c19e3b4880eee6d2fcabd0d879121e282196b80042351d5eb3ca0935fa599da1dc51265cc68816ad2bddd2a2de5ea9fdf92adbec7cd34"
"packageManager": "pnpm@10.33.0+sha512.10568bb4a6afb58c9eb3630da90cc9516417abebd3fabbe6739f0ae795728da1491e9db5a544c76ad8eb7570f5c4bb3d6c637b2cb41bfdcdb47fa823c8649319"
}
2 changes: 1 addition & 1 deletion src/lib/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const URLRecord = z.object({
id: z.coerce.number(),
is_custom: z.boolean(),
original_url: z.string().url(),
short_code: z.string().max(20),
short_code: z.string().max(25),
created_at: z.coerce.date(),
updated_at: z.coerce.date(),
click_count: z.number().int().nonnegative(),
Expand Down
19 changes: 6 additions & 13 deletions src/lib/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
import { z } from "zod"

export const createUrlSchema = z.object({
export const editUrlSchema = z.object({
url: z.string().url("Invalid URL format"),
shortCode: z
.string()
.min(2, "Short code must be at least 3 characters")
.max(20, "Short code must be at most 20 characters")
.min(2, "Short code must be at least 2 characters")
.max(25, "Short code must be at most 25 characters")
.regex(
/^[a-zA-Z0-9_-]+$/,
"Short code can only contain letters, numbers, hyphens and underscores"
)
.optional(),
),
})

export type CreateUrlInput = z.infer<typeof createUrlSchema>

export const editUrlSchema = createUrlSchema.extend({
shortCode: z
.string()
.min(2)
.max(20)
.regex(/^[a-zA-Z0-9_-]+$/),
export const createUrlSchema = editUrlSchema.extend({
shortCode: editUrlSchema.shape.shortCode.optional(),
})
Loading