feat: add en-XE (cross-Europe English) and es-XA (cross-Latin America Spanish) surfaces - #1279
feat: add en-XE (cross-Europe English) and es-XA (cross-Latin America Spanish) surfaces#1279mmiermans wants to merge 1 commit into
Conversation
|
Claude finished @mmiermans's task in 1m 23s —— View job Code ReviewReviewed the diff against
1. Display names break the established naming convention (and contradict the PR description) —
|
af99005 to
c9d4f2f
Compare
673d479 to
2e35123
Compare
… Spanish) surfaces Adds the NEW_TAB_EN_XE and NEW_TAB_ES_XA scheduled surfaces to the curation tool so curators can manage ML sections for the cross-Europe English (en_XE) and cross-Latin America Spanish (es_XA) markets. - definitions.ts: add both guids to the readable-name list. - getScheduledSurfacesForUser mock: add both surfaces (en-XE -> Europe/Berlin, es-XA -> America/Mexico_City), matching the surface timezones in Pocket/content-monorepo#397. - ScheduleItemFormConnector test: include both new guids. Companion to Pocket/content-monorepo#397 and mozilla/content-ml-services#1243. Follows the pattern of #1274 (de-AT / de-CH / pl-PL / fr-BE).
2e35123 to
be7c44b
Compare
Goal
Add scheduled surfaces for cross-Europe English (
en_XE→NEW_TAB_EN_XE) and cross-Latin America Spanish (es_XA→NEW_TAB_ES_XA) to the curation tool, so curators can manage ML sections for these two new markets.Companion to Pocket/content-monorepo#397 (backend) and mozilla/content-ml-services#1243 (ML pipeline). Timezones mirror the backend:
en-XE→Europe/London,es-XA→Europe/Madrid.Follows the pattern of #1274 (de-AT / de-CH / pl-PL / fr-BE).
Changes
helpers/definitions.ts: add both guids to the readable-nameScheduledSurfaceslist.integration-test-mocks/getScheduledSurfacesForUser.ts: add both surfaces to the mock.ScheduleItemFormConnector.test.tsx: include both new guids in the surface-count assertion.No language-picker change is needed —
getLocaleForScheduledSurfaceinfers the locale directly from the guid (NEW_TAB_EN_XE→en-XE,NEW_TAB_ES_XA→es-XA), and EN/ES already exist.Deployment steps
mozilliansorg_pocket_new_tab_curator_enxe/_esxato be created, or curators will get a 403.QA