You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @nphuly, thanks for working on this proofreading!
Before I finalize, I need to understand your intent on one recurring change. Depending on your answer, I'll either revert or apply it consistently across the full course + quizzes.
Please answer with intentional / not intentional:
"bản trắng" / "bài báo trắng" / "bản thảo trắng" → "white paper" — Was the move toward English white paper intentional? At vi.md:33 you introduced a bilingual pattern white paper (sách trắng), but elsewhere the VI gloss is dropped (e.g. vi.md:327 uses bare white paper), and three older VI variants still appear in vi.md (8× bài báo trắng, 7× bản trắng, 3× bản thảo trắng) plus bản trắng in quizz/016/vi.yml and quizz/026/vi.yml. There's also a hybrid bản white paper at vi.md:402 that looks unintended.
If you confirm white paper (sách trắng) on first mention and white paper thereafter as the target form, I'll do the consistency sweep across vi.md and the two quiz files before merging. If you'd rather keep the Vietnamese bản trắng / sách trắng everywhere, just say which one and I'll align in the other direction.
Just let me know and I'll take care of making everything consistent before merging. Thanks!
white paper is intentional. Like mining, white paper refers to a specific type of technical document and doesn't map cleanly to any of the existing Vietnamese variants (bản trắng, bài báo trắng, bản thảo trắng), all of which read awkwardly in context. Please apply white paper (sách trắng) on first mention and bare white paper thereafter, consistent with the gloss-on-first-mention policy from the previous thread. The hybrid bản white paper at vi.md:402 looks unintended; feel free to fix that too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4441