Skip to content

fix(control_system): [PPT-2460] empty string in camera_snapshot_urls#310

Merged
stakach merged 5 commits into
masterfrom
PPT-2460
Apr 28, 2026
Merged

fix(control_system): [PPT-2460] empty string in camera_snapshot_urls#310
stakach merged 5 commits into
masterfrom
PPT-2460

Conversation

@chillfox
Copy link
Copy Markdown
Contributor

No description provided.

@chillfox chillfox self-assigned this Apr 21, 2026
@chillfox chillfox changed the title Ppt 2460 fix(control_system): [PPT-2460] empty string in camera_snapshot_urls Apr 21, 2026
@github-actions
Copy link
Copy Markdown

Hey, your PR is titled Ppt 2460.
This is not a valid conventional commit.
Since we use well-formed PR titles for our changelogs, not fixing this can introduce problems :'(

@chillfox chillfox requested review from naqvis and stakach April 21, 2026 07:57
Copy link
Copy Markdown
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be stripping blank URLs if anything - we needed them for a bit due an issue migrating away from a single URL to multiple.

But now blank strings should be removed without erroring

@github-actions github-actions Bot added the type: bug something isn't working label Apr 28, 2026
@chillfox chillfox requested a review from stakach April 28, 2026 01:37
@github-actions github-actions Bot added type: bug something isn't working and removed type: bug something isn't working labels Apr 28, 2026
@stakach stakach merged commit 4518766 into master Apr 28, 2026
8 checks passed
@stakach stakach deleted the PPT-2460 branch April 28, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants