Manual Cherry-pick needed: cfa70fac4eec2f803088bbeeffce4ce5101be740 - #231
Closed
github-actions[bot] wants to merge 119 commits into
Closed
Manual Cherry-pick needed: cfa70fac4eec2f803088bbeeffce4ce5101be740#231github-actions[bot] wants to merge 119 commits into
github-actions[bot] wants to merge 119 commits into
Conversation
Fabric's menu API refuses to open a menu whose type is an ExtendedMenuType unless the MenuProvider also implements net.fabricmc.fabric.api.menu.v1.ExtendedMenuProvider. Our own core.mc261.ExtendedMenuProvider does not, so every extended menu registered through ExtendedScreenHandlerTypeBuilder threw IllegalArgumentException on open and the screen silently never appeared. Route both openExtendedMenu overloads through a new @ExpectPlatform MenuOpener. The Fabric implementation wraps the provider in one that does implement Fabric's interface; NeoForge keeps the previous behaviour.
CompatibleArmorMaterial#build passes 0 as the durability multiplier, so humanoidArmor sets a max damage of 0 on every armor item built through CompatibleArmorItem. Vanilla damages every worn piece when the player is hit, so a single hit destroys the whole set at once, and the durability bar reads empty until it does. The multiplier cannot be recovered from the material: it reports an absolute durability per slot, while vanilla multiplies one shared value by a per slot constant, so no single multiplier reproduces all four. Apply the material's own value per item after humanoidArmor has run instead, and leave build alone since it is already deprecated.
Added ModParks link in README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of cfa70fa from 1.26.2 to 1.26.1 failed due to conflicts.