chore(tools): share model-facing output markers between emitters and matchers#93
Open
davidrhodus wants to merge 1 commit into
Open
chore(tools): share model-facing output markers between emitters and matchers#93davidrhodus wants to merge 1 commit into
davidrhodus wants to merge 1 commit into
Conversation
…matchers
Steering string-matched literals that hi-tools emitted from separate
definitions; the two drifted ("[timed out after " vs the emitted
"[timed out — process killed]"), leaving the timed-out matcher dead
until the annotation work caught it. Export the markers from
hi_tools::markers, emit and match through the same constants, and keep
test assertions as verbatim literals so changing a marker is a
conscious, test-breaking decision.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #88. Steering string-matched literals that hi-tools emitted from separate definitions, and the two drifted ("[timed out after " vs the emitted "[timed out — process killed]"), leaving the timed-out matcher dead until #88 caught it. Export
hi_tools::markers, emit and match through the same constants, and keep test assertions as verbatim literals so changing a marker is a conscious, test-breaking decision.🤖 Generated with Claude Code