refactor: turn cleanup API, TurnState, impl cascade, tools split#127
Merged
Merged
Conversation
Unify abnormal turn teardown via cleanup_turn (Cancel/Fail) across CLI, TUI, REPL, sync, and explore children. Own per-turn loop state in TurnState, table-drive implementation completeness gates, add domain setter APIs, lint hi-tools protocol/infra imports in the turn loop, and split tools into tools/batch plus model_request helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TurnCleanupKind/SessionRollback/cleanup_turn— single abnormal teardown path (CLI, TUI, REPL, sync, explore).TurnStatebag; model/verify project from it instead of a giant local list.IMPLEMENTATION_COMPLETENESS_CASCADEfor no-change / scaffold / validation gates.begin_turn,set_outcome,set_task*,try_begin_*).protocol_import_linttests for turn-loophi_tools::protocol/infraimports.tools/{mod,batch}.rs+model_request.rshelpers.Test plan
cargo test --manifest-path crates/hi-agent/Cargo.toml --lib(635 passed)cargo check --manifest-path crates/hi-cli/Cargo.tomlcargo check --manifest-path crates/hi-tui/Cargo.toml