refactor: turn phase SM, Agent domains, steer cascade, typed exits#126
Merged
Conversation
Encode legal TurnPhase transitions, mirror cancel/failed cleanup for turn-scoped backgrounds and explore children, compose Agent into task/ report/workspace/subagent holders, table-drive review quality repairs from REVIEW_QUALITY_CASCADE, soft-firewall hi-tools protocol vs infra, and centralize one-shot exit codes on TurnOutcome plus TopLevelErrorKind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TurnPhasetransitions and keep cancel/failed paths tearing down turn-scoped backgrounds (including explore children).Agentinto task/report/workspace/subagent domain holders; table-drive review quality repairs fromREVIEW_QUALITY_CASCADE.hi-toolsprotocol vs infra; centralize one-shot exit codes onTurnOutcomeandTopLevelErrorKind.Test plan
cargo test --manifest-path crates/hi-agent/Cargo.toml --lib(630 passed)cargo test --manifest-path crates/hi-cli/Cargo.toml -- one_shot_exitcargo check --manifest-path crates/hi-cli/Cargo.toml