ci: fix red test job (provide DATABASE_URL) - #38
Merged
Conversation
The app instantiates Settings() (which requires DATABASE_URL: PostgresDsn) at
import time, so with no DATABASE_URL the CI test job errored at collection
("database_url Field required", 0 items collected) — red since Oct 2025. The
suite is fully mocked and opens no real connection, so a valid dummy DSN is
enough. A postgres/postgis service can be added later if tests exercise a live DB.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Typer/Rich colourises option names in CI (FORCE_COLOR), rendering '--bbox' as '\x1b[..m-\x1b[0m\x1b[..m-bbox\x1b[0m', so the literal substring check failed there while passing in a plain local terminal. Strip ANSI before matching. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's
testjob has been red since Oct 2025: the app instantiatesSettings()(which requiresDATABASE_URL: PostgresDsn) at import, andci.ymlset noDATABASE_URL, so pytest errored at collection (database_url Field required, 0 items).Fix: set a valid dummy
DATABASE_URLfor theRun testsstep. The suite is fully mocked (the only DB-touching test usesDummyPersister/DummyInspectorand never opens a connection), so no live Postgres is needed. Verified locally by hiding.envand running with only the env var:Settings()imports and 96 tests pass.A
postgres/postgisservice can be added when tests exercise a live DB.🤖 Generated with Claude Code