Fail closed for non-affine NAX quantization - #1
Closed
PhilipJohnBasile wants to merge 1 commit into
Closed
Conversation
7 tasks
PhilipJohnBasile
marked this pull request as ready for review
August 24, 2026 01:44
Owner
Author
|
Archiving this stacked 2.4-era component PR with its parent integration stack. It is not part of the current 2.9.1 mainline or upstream PR youssofal#336. The branch and commit remain preserved; any still-relevant affine-guard change should return later as a small rebase onto current upstream main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
MTPLX custom NAX and vk verification kernels consume affine quantization biases. This patch preserves stock MLX execution for every QuantizedLinear mode other than affine before any custom dispatch or affine-only tensor access.
Evidence
This is a fail-closed compatibility fix, not a speed claim.