Skip to content

chore: fix migration collision, orphan index, and AUDIT typo on develop#42

Open
AlexMakesC0de wants to merge 1 commit into
developfrom
chore/develop-cleanup
Open

chore: fix migration collision, orphan index, and AUDIT typo on develop#42
AlexMakesC0de wants to merge 1 commit into
developfrom
chore/develop-cleanup

Conversation

@AlexMakesC0de

@AlexMakesC0de AlexMakesC0de commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Cleans up three issues that landed on develop via #40, before they bite anyone.

Changes

  1. Duplicate migration number. develop had two 009 migrations (009_activity_notifications_realtime.sql and 009_fix_item_photos_upload_scoping.sql). Renamed the upload-scoping one to 010_fix_item_photos_upload_scoping.sql so ordering is unambiguous. 011 is unchanged.
  2. Orphan index in init.sql. Improved quality #40 dropped the account_authentication table but left CREATE INDEX ... ON account_authentication at line 153, so a fresh init.sql run failed with "relation does not exist". Removed that line.
  3. AUDIT.md header typo. A stray link was pasted into the word "Severity". Fixed, and updated the upload-scoping migration references from 009 to 010 to match the rename.

Notes

No code or schema behavior changes. The renamed migration file content is identical. The activity-notifications 009 migration is intentionally left as-is. Separately, still open from the #40 review: migration 011 (server-side purchase fee trigger) is written but not yet confirmed applied to the hosted project.

@AlexMakesC0de AlexMakesC0de force-pushed the chore/develop-cleanup branch from abbf4b5 to d5a6b13 Compare June 22, 2026 17:56
@NickGrahovskis

Copy link
Copy Markdown
Collaborator

The fixes for sql files are redunant bcs we will delete them, so only add changes to audit.md. If you want you can also delete the whole db folder, because it was only needed for local supabase which we are not using anymore

Per review on PR #42, drop the redundant SQL migration edits (the database folder is already removed on develop) and keep only the AUDIT.md fixes. Rebuilt on develop so the PR is a single AUDIT.md change.
@AlexMakesC0de AlexMakesC0de force-pushed the chore/develop-cleanup branch from d5173a2 to 972125c Compare July 6, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants