Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions changelog.d/9044-build-cache-codegen-env-vars.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
`PERRY_BOX_CAPTURE_ENTRY_CELLS` and `PERRY_GUARDED_PREINLINE_MAX_IR_BYTES` are
now build-cache inputs.

Both landed without build-cache registration, so
`codegen_env_vars_are_build_cache_inputs` failed on `main` — and because it is a
`perry` bin-crate unit test, the whole `perry` test binary failed to compile,
turning every open PR's cargo-test job red.

Both are inputs rather than exclusions because both change emitted code: the
capture-cell knob changes every closure body that qualifies for entry-resolved
box cells, and the preinline ceiling changes which functions inline, so a run
with a raised ceiling must not be served objects a default run produced. That
is #6394's rule — a codegen env var keys the cache or carries a written reason
it cannot affect output.
8 changes: 8 additions & 0 deletions crates/perry/src/commands/compile/build_cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ const BUILD_CACHE_ENV_VARS: &[&str] = &[
// `disable-tail-calls` before the optimizer. It changes the generated
// code of the functions it trips on, so it is a cache input.
"PERRY_LL_TRE_MAX_ALLOCA_WALK",
// #9026: gates the once-per-closure-entry resolution of read-only boxed
// capture cells — flipping it changes every closure body that qualifies.
"PERRY_BOX_CAPTURE_ENTRY_CELLS",
// The guarded-preinline IR-size ceiling: functions on either side of the
// budget inline differently, so a run with a raised ceiling must not be
// served objects a default run produced (same rule as the RS4GC budget
// above).
"PERRY_GUARDED_PREINLINE_MAX_IR_BYTES",
// #8583: the relocation estimate above which a function spills its GC roots
// to a shadow frame. It changes which functions carry statepoints, so it
// changes the generated code and must be a cache input.
Expand Down
Loading