fix(codegen): split gc_map tests to a sibling file for the 2000-line cap - #8957
Merged
Conversation
#8948 took gc_map.rs to 2047 lines and `check_file_size` has been red on main since it merged. I had prepared this split during that PR's review but pushed it to the wrong remote — #8948 is same-repo, and the push went to a fork the PR does not track — so the unfixed head is what merged. Moved the cfg(test) module out verbatim via the #[path] pattern the tree already uses (1332 + 712 lines).
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe inline GC map test module moved to ChangesGC map test extraction
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_file_sizehas been red onmainsince #8948 merged: it takesgc_map.rsto 2047 lines, over the cap.I prepared this split while reviewing #8948 but pushed it to the wrong remote — #8948 is same-repo (
headRepo=PerryTS) and I pushed to a contributor fork the PR does not track, so the unfixed head is what merged. The push succeeded silently, which is why I did not catch it until the next PR's gate run flagged the file.The fix itself is unchanged: the
cfg(test)module moves togc_map_tests.rsverbatim via the#[path]pattern the tree already uses (1332 + 712 lines).Validation: codegen 1337/0,
cargo fmtclean,scripts/run_lint_gates.sh57 of 58 including the compile tier — the exception is the pre-existing\${{ }}substitution artifact (#8929).Summary by CodeRabbit