batch: land #8892, #8893, #8894 - #8898
Merged
Merged
Conversation
…erenceError Coop's Next.js App Route fixture died at module init on 0.5.1519 with the nameless `ReferenceError: identifier is not defined`. The identifier is `SentinelNode` in next/dist/server/lib/lru-cache.js: the CJS wrap hoists `LRUCache` out of the module IIFE but never sees `SentinelNode` (its doc comment closes on the `class` line, and the textual hoister anchors on `class ` at column 0), so the hoisted constructor's `new SentinelNode()` is lowered before the `__perry_cjs_factory` body registers the class. The unresolved-`new` guard from #8643 (905017b, inside the 1516..1519 window) turned that lowering-time miss into an unconditional nameless throw; before it, the by-name `Expr::New` bound at codegen through the module class table, which is why 0.5.1516 loaded. - `pre_scan_class_decl_names` records every class DECLARATION name in the module at any depth; the guard keeps the late-bound by-name construction for those. - Any other unresolved constructor is read off `globalThis` when the `new` executes (`js_global_get_or_throw_unresolved`, shared with the bare-identifier arm via `unresolved_global_get_expr`), so a runtime-created global constructs and a true miss throws `ReferenceError: <name> is not defined` -- with the identifier, as #8730 and #8882 asked. The compile log names it too, with the same "unknown identifier" warning the bare-identifier arm prints. Regression tests: a hoisted class constructing a sibling declared inside a later closure keeps `New { class_name }` (fails without the new guard clause, verified); a `typeof`-guarded `new IntersectionObserver()` lowers to the named runtime lookup; the #8739 positive control now expects the named form. Fixes #8882. Refs #8730. Claude-Session: https://claude.ai/code/session_01UZJbhb2FTuakurTHPAKQgd
…host several apps Every class-id-keyed table module init writes — vtables, static methods and accessors, constructors and flags, the parent map and its dense mirror, names, lengths, registered ids, bind lengths, the extends-Error / DataView / typed-array marks, the hasInstance / toStringTag hooks, generic-origin and fetch-parent maps, anon-shape ids — was a process-global static keyed by a compile-time class id. Class ids come from a small sequential counter in codegen, so N dlopen'd copies of one application register the SAME ids with DIFFERENT func_ptrs (each image's own code addresses) into one HashMap, and insert is last-writer-wins: after the last image's init every class of every earlier image dispatched into the last image's code, and only the last-initialised application worked (#8546). No write order over a shared table works, so the 21 tables move into one ClassImageTables per image. A thread resolves its image through a perry_thread_local! handle, falling back to the process-wide primary image. js_gc_init — codegen's first runtime call in both `main` and `perry_module_init`, on the thread that runs that image's module init — enters an image: the first thread to enter owns the primary, every later one gets a fresh image. perry/thread workers and worker_threads Workers adopt their spawner's image before running anything, because they never run module init. A thread that neither entered nor adopted (a pump firing JS for the primary heap, a reactor thread, a libtest thread) uses the primary, i.e. the process-global table it saw before, so single-image programs are unchanged. Each former `static RwLock<..>` is a `static ImageTable<RwLock<..>>` whose read()/write() return the same guard types, so the call sites are untouched. Latches and VTABLE_GEN stay process-global on purpose. Tests: two application threads registering the same class id with different method addresses each dispatch to their own (sabotage-verified: with the enter made a no-op the last writer wins and the test fails on the func_ptr); a spawned worker shares its spawner's image while a second application sees neither; a thread without an image reads the primary. Claude-Session: https://claude.ai/code/session_01UZJbhb2FTuakurTHPAKQgd
…nctions `TailCallElimPass::markTails` walks the transitive SSA uses of every alloca; only loads/stores and nocapture call arguments stop it. On a statepoint-rewritten function an alloca handed to any runtime call reaches the statepoint token, its gc.relocates and, through their gc-live bundles, every later statepoint, so each walk covers the whole function and the pass costs allocas x uses. Coop's Next.js route (jsonwebtoken's bundled entry: 400 allocas, 643k post-RS4GC instructions, 3.4k statepoints, 477k relocates; ~1.6M visited uses per alloca) held one LLVM worker for ~100 CPU-minutes in that walk on a unit whose remaining `-Os` passes take ~16 s. Before the optimization pipeline runs, estimate the walk as `allocas x instructions` per function and stamp `"disable-tail-calls"="true"` on any function over the budget (default 2^26; `PERRY_LL_TRE_MAX_ALLOCA_WALK=<n>` raises/lowers it, `0`/`off` disables). That attribute is TRE's own early-out, so the function keeps every other pass at the requested level (#8421); it gives up exactly tail-recursion-to-loop and sibling-call codegen, and it is not `optnone` (#8583). The trip is logged with the function's name and factors, and the knob is a build/object cache input. Fixes #8883 Claude-Session: https://claude.ai/code/session_01UZJbhb2FTuakurTHPAKQgd
This was referenced Aug 27, 2026
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (30)
📝 WalkthroughWalkthroughThe PR adds runtime resolution for unresolved constructors, per-image class registries with worker propagation, and a configurable TailCallElim walk budget with cache-key integration and regression tests. ChangesLate-bound constructor resolution
Per-image class registries
TailCallElim walk budget
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant ModuleLowering
participant ClassNamePreScan
participant LowerNew
participant RuntimeGlobalLookup
ModuleLowering->>ClassNamePreScan: scan module class declarations
ClassNamePreScan-->>ModuleLowering: return class_decl_names_any_depth
ModuleLowering->>LowerNew: lower new Identifier()
LowerNew->>RuntimeGlobalLookup: resolve unresolved identifier at runtime
RuntimeGlobalLookup-->>LowerNew: constructor or named ReferenceError
sequenceDiagram
participant js_gc_init
participant ClassImage
participant ImageTable
participant Worker
js_gc_init->>ClassImage: enter current thread image
ClassImage-->>ImageTable: select image-local registry
Worker->>ClassImage: adopt spawner image
Worker->>ImageTable: access shared class tables
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch landing of three reviewed PRs, validated once as a single merged tree. No fixes needed — all three gate-clean as submitted.
new X()to a class declared later in the module#8891 and #8896 are not in this batch:
arch(gc) phase 1) is being validated separately in its own worktree, with a moving-GC A/B — it changes GC tracing, so it gets its own pass rather than a batch slot.addr_class_inventory,gc_runtime_root_holders,raw_handle_debt). Three at once is not a formality; it needs a proper look.Validation (merged tree)
perry-runtime2755,perry-codegen1328,perry-stdlib124,perry-hir350 — all 0 faileddfchecked before and after; no result produced under ENOSPCSummary by CodeRabbit
Bug Fixes
Performance