land #8864: clear v0.5.1519 r19 release blockers - #8866
Merged
Conversation
|
Warning Review limit reachedNext included review available in 11 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #8864 (
fix: clear v0.5.1519 r19 release blockers). No fixes were needed — it merged clean and every gate passed as submitted.Why the
C-unwindchange is the right shapeBlanket
extern "C-unwind"conversion has burned this repo: #8464 did it broadly, measured +20 crashes under gc-stress, and was reverted in #8484. So this got a close look.This is the opposite case — two specific boundaries that genuinely throw:
Both call
throw_not_callable(), which raises a Perry exception through the system unwinder to generated code's landing pad. A plainextern "C"boundary turns that catchable throw intopanic_cannot_unwindand aborts the process — so the conversion restores a caughtTypeErrorrather than widening the unwind surface. The keepalive anchor's fn-pointer type is updated in sync, keeping the generated-code-only ABI consistent.Interaction with #8861, checked
It removes the old single-slot
"end" | "close"arm fromremoveListener, which #8861 superseded. Verified after merging that the replacement is intact: the list-based arm survives atreadline/mod.rs:1651, and the&STDIN_END_CALLBACKSentry added toscan_readline_roots_mutwhile landing #8861 survives at:267. SoremoveListenerfor stdinendstill works, and those closures are still rooted.Validation (merged tree)
perry-runtime2705,perry-codegen1270,perry-stdlib122 — all 0 failedPERRY_GC_FORCE_EVACUATE=1 PERRY_GC_VERIFY_EVACUATION=1): 16 failed on the batch and 16 on cleanmain— same-commit A/B. Run deliberately because of fix(runtime): extend #8416's C-unwind to the whole closure dispatch family (#8463) #8464's history in this exact area.dfchecked before and after; no result produced under ENOSPCThe PR's own r19 CI evidence (cargo-test, parity shard 12, simulator) is cited in its description.