Skip to content

ci: restore parity release margin - #8846

Merged
proggeramlug merged 1 commit into
mainfrom
fix/release-parity-budget
Aug 26, 2026
Merged

ci: restore parity release margin#8846
proggeramlug merged 1 commit into
mainfrom
fix/release-parity-budget

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • spread release-grade parity over 12 shards instead of 8
  • raise the parity job hang backstop from 150 to 210 minutes
  • track the Linux-only test_parcel_watcher_facade CI mismatch surfaced by the release candidate

Release evidence

Full candidate run 32922022811 cancelled parity shard 8 at the exact 150-minute cap while it was still making progress (152/173 tests completed). The shard was not hung. All other observed mismatches in the partial report were already present in test-parity/known_failures.json; the Parcel watcher facade mismatch was the only untracked result.

No publisher was dispatched, and no npm package, tag, or GitHub Release was created.

Validation

  • python3 scripts/ci_plan.py --self-test
  • full dispatch plan emits parity shards 1-12
  • python3 scripts/parity_report_merge.py --self-test
  • python3 scripts/parity_known_failures.py --self-test
  • python3 scripts/parity_known_failures.py --audit
  • jq empty test-parity/known_failures.json
  • git diff --check

Summary by CodeRabbit

  • CI Improvements

    • Release-parity checks now run across 12 parallel shards for improved execution capacity.
    • Increased the parity check timeout to provide additional completion time.
  • Known Issues

    • Documented a Linux-specific Parcel watcher mismatch in the tracked known-failures list.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e2a03240-7f82-4a40-9c78-0f0e45f5b01e

📥 Commits

Reviewing files that changed from the base of the PR and between 846f71c and b12dedc.

📒 Files selected for processing (4)
  • .github/workflows/test.yml
  • changelog.d/8841-release-parity-budget.md
  • scripts/ci_plan.py
  • test-parity/known_failures.json

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Release parity CI increases from eight to twelve shards and raises the shard timeout from 150 to 210 minutes. The change also records a Linux-specific Parcel watcher facade failure in the known-failures registry and changelog.

Changes

Release parity updates

Layer / File(s) Summary
Parity shard capacity and timeout
scripts/ci_plan.py, .github/workflows/test.yml
Parity execution now uses 12 shards. The workflow documents the change and increases the timeout to 210 minutes.
Linux watcher failure tracking
test-parity/known_failures.json, changelog.d/8841-release-parity-budget.md
The Linux-specific test_parcel_watcher_facade failure is registered with diagnostic details and documented in the changelog.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b12de

This PR expands parity testing to 12 shards, raises the CI timeout backstop, and records an already observed Linux-only mismatch; the supplied validation is clean, so no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: thehypnoo

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides a clear summary, release evidence, and validation details. It omits the template's Changes, Related issue, and Checklist sections, and uses non-template headings instead of an… Add the required Changes, Related issue, and Checklist sections. Convert Validation into a Test plan section, and reference issue 8841 or state "n/a".
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: restoring release parity margin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description provides a clear summary, release evidence, and validation details. It omits the template's Changes, Related issue, and Checklist sections, and uses non-template headings instead of an explicit Test plan section.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-parity-budget

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit b83a903 into main Aug 26, 2026
50 checks passed
@proggeramlug
proggeramlug deleted the fix/release-parity-budget branch August 26, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant