ci: restore parity release margin - #8846
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughRelease parity CI increases from eight to twelve shards and raises the shard timeout from 150 to 210 minutes. The change also records a Linux-specific Parcel watcher facade failure in the known-failures registry and changelog. ChangesRelease parity updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR expands parity testing to 12 shards, raises the CI timeout backstop, and records an already observed Linux-only mismatch; the supplied validation is clean, so no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description provides a clear summary, release evidence, and validation details. It omits the template's Changes, Related issue, and Checklist sections, and uses non-template headings instead of an explicit Test plan section. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
test_parcel_watcher_facadeCI mismatch surfaced by the release candidateRelease evidence
Full candidate run 32922022811 cancelled parity shard 8 at the exact 150-minute cap while it was still making progress (152/173 tests completed). The shard was not hung. All other observed mismatches in the partial report were already present in
test-parity/known_failures.json; the Parcel watcher facade mismatch was the only untracked result.No publisher was dispatched, and no npm package, tag, or GitHub Release was created.
Validation
python3 scripts/ci_plan.py --self-testpython3 scripts/parity_report_merge.py --self-testpython3 scripts/parity_known_failures.py --self-testpython3 scripts/parity_known_failures.py --auditjq empty test-parity/known_failures.jsongit diff --checkSummary by CodeRabbit
CI Improvements
Known Issues