fix: avoid NOT NULL in Snowflake merge casts - #4683
Open
jamesg31 wants to merge 1 commit into
Open
Conversation
jamesg31
requested a deployment
to
external-contributor
August 10, 2026 20:48 — with
GitHub Actions
Waiting
jamesg31
requested a deployment
to
external-contributor
August 10, 2026 20:48 — with
GitHub Actions
Waiting
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
PR #3893 fixed the same Snowflake syntax failure by keeping nullability out of CAST types. PR #3923 later routed
TableSchema.NullableEnabledintoToDWHColumnTypefrom the MERGE generator, which can emit invalid expressions such asCAST(... AS TIMESTAMP_TZ NOT NULL).The Snowflake connector is deprecated, but this is a focused regression repair for existing deployments.
Test
go test ./connectors/snowflake -run '^TestGenerateMergeStatementNullableSchemaDoesNotAddNotNullToCasts$'