Fix/clickhouse normalize cursor skip - #4675
Open
matheusgr wants to merge 5 commits into
Open
Conversation
… tables When normalize finds no destination tables (connections=0) but the batch range still has rows in the raw table or a non-empty avro stage, return an error instead of calling UpdateNormalizeBatchID. This lets the normalize loop retry and prevents permanently skipping CDC batches. Empty CDC batches (zero avro records and zero raw rows) still advance the cursor as before. Co-authored-by: Cursor <cursoragent@cursor.com>
matheusgr
had a problem deploying
to
external-contributor
August 6, 2026 16:30 — with 
GitHub Actions
Failure
GitHub Actions
Failure
matheusgr
had a problem deploying
to
external-contributor
August 6, 2026 16:30 — with
GitHub Actions
Failure
GitHub Actions
Failure
|
|
matheusgr
had a problem deploying
to
external-contributor
August 6, 2026 16:49 — with
GitHub Actions
Failure
GitHub Actions
Failure
matheusgr
had a problem deploying
to
external-contributor
August 6, 2026 16:49 — with
GitHub Actions
Failure
GitHub Actions
Failure
…ze dropping rows On the 3-replica prod cluster, normalize writes the raw table and then reads it back via INSERT ... SELECT, potentially on a different replica. Raw inserts were already synchronous (insert_distributed_sync/distributed_foreground_insert), and select_sequential_consistency was set, but that setting only guarantees visibility of quorum-inserted blocks -- with the default insert_quorum=0 it enforces nothing, so the read could return zero rows, mark the batch normalized, advance the cursor, and drop those rows permanently. Write raw/normalize inserts with insert_quorum=auto and insert_quorum_parallel=0 on Replicated clusters, gated by PEERDB_CLICKHOUSE_ENABLE_REPLICATED_QUORUM (default true here since prod is replicated and actively affected). Ported from upstream PeerDB 053ba64 (v0.37.5), kept as a fork patch to preserve the normalize-cursor guard and raw-table TTL commits on this branch. Co-authored-by: Cursor <cursoragent@cursor.com>
matheusgr
requested a deployment
to
external-contributor
September 4, 2026 17:56 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
matheusgr
requested a deployment
to
external-contributor
September 4, 2026 17:56 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Co-authored-by: Cursor <cursoragent@cursor.com>
matheusgr
requested a deployment
to
external-contributor
September 4, 2026 18:11 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
matheusgr
requested a deployment
to
external-contributor
September 4, 2026 18:11 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.