Skip to content

Honor print job copies - #255

Merged
PedroBMR merged 1 commit into
mainfrom
codex/update-enqueue_job-to-support-copies-parameter
Dec 10, 2025
Merged

Honor print job copies#255
PedroBMR merged 1 commit into
mainfrom
codex/update-enqueue_job-to-support-copies-parameter

Conversation

@PedroBMR

Copy link
Copy Markdown
Owner

Summary

  • persist requested copy counts on queued print jobs and send payloads repeatedly per job
  • add schema migration and data access changes to store the number of copies
  • cover multiple-copy handling in the print queue tests

Testing

  • pytest tests/db/test_print_jobs_queue.py

Codex Task

@PedroBMR
PedroBMR merged commit 14e08aa into main Dec 10, 2025
1 check failed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread printing/queue.py
Comment on lines 120 to +124
break
db_store.update_print_job_status(job_id=job_id, status="running")
try:
target.send(payload)
for _ in range(copies):
target.send(payload)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid resending already printed copies after retry

Within each retry attempt all requested copies are sent in one loop; if target.send raises after printing some copies, the except block triggers a retry of the entire loop on the next attempt, causing more copies to be printed than requested whenever a transient failure happens mid‑batch. This overprints labels for multi‑copy jobs; consider tracking remaining copies or aborting without reissuing copies already sent.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant