Add printer host/port persistence for print jobs - #249
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| "printer_transport", | ||
| "printer_host", | ||
| "printer_port", | ||
| "media_settings", | ||
| "pending_at", |
There was a problem hiding this comment.
[P1] Migrating print_jobs drops existing printer metadata
Adding printer_host/printer_port to expected_print_job_columns causes _migration_1 to rebuild the print_jobs table for every existing database. The subsequent copy loop still only reinserts id, created_at, template_name, payload and status, so any pre‑existing jobs lose their printer_backend, printer_transport, media_settings and other fields. After upgrading, previously queued jobs can no longer be replayed with the correct printer configuration. Consider adding the new columns via ALTER TABLE or copying all columns when recreating the table to preserve existing data.
Useful? React with 👍 / 👎.
Summary
print_jobsschema and data layer to store printer host/port informationTesting
https://chatgpt.com/codex/tasks/task_e_68dbfb73a65c832c9b741f5e92f36b68