Skip to content

Format codebase for Ruff compliance - #245

Merged
PedroBMR merged 1 commit into
mainfrom
codex/fix-linting-issues-with-ruff
Sep 30, 2025
Merged

Format codebase for Ruff compliance#245
PedroBMR merged 1 commit into
mainfrom
codex/fix-linting-issues-with-ruff

Conversation

@PedroBMR

Copy link
Copy Markdown
Owner

Summary

  • wrap long expressions, SQL statements, and UI style strings to satisfy Ruff E501 across runtime modules and tests
  • reorganize import blocks and remove unused helpers for consistent Ruff/PEP 8 ordering
  • refactor tests and helper utilities to avoid long lambdas and align with linting expectations

Testing

  • ruff check .

https://chatgpt.com/codex/tasks/task_e_68dbda7d05ac832cb0f86cf8036a363d

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread printing/__init__.py
Comment on lines 27 to 31
from utils import recurso_caminho
from utils.fs import canonical_path as canonical_file_path

from .queue import PrinterTarget, enqueue_job, shutdown as shutdown_print_queue, start as start_print_queue, wait_for_all as wait_for_all_jobs
from .queue import PrinterTarget, enqueue_job

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Restore queue helper exports removed from printing module

The formatting pass trimmed the queue import to only PrinterTarget and enqueue_job, dropping start_print_queue, shutdown_print_queue, and wait_for_all_jobs. Those names were previously re-exported by this module and are still imported by the test suite and likely any external callers. After this change from printing import wait_for_all_jobs now raises an ImportError, so the public printing API no longer exposes the queue control helpers. Either restore the re-export or update all call sites to import directly from printing.queue.

Useful? React with 👍 / 👎.

@PedroBMR
PedroBMR merged commit 1eff799 into main Sep 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant