Make the username the only name the site shows - #389
Merged
Conversation
User.DisplayName is dropped. It was Clerk's first name, synced into a column, freely editable and not unique, and only ever set by people who signed up with email. The username replaces it everywhere: comments, the avatar menu, the contact prefill, the admin review. Sign-up asks for email and password. Nothing throws on an account that carries no name any more, which is what stopped a Discord or GitHub signup writing a user row at all. A deleted account is now withheld rather than relabelled. The projections hand over null and whoever renders it says who that is in the reader's own language, so no English "Deleted User" string is stored in the database, and the admin review withholds the name the way it already withholds the address. The username itself stays on the row, reserved. Identity comes from one place while we are here: the profile carries the address as well as the name, so the header, the contact form and the profile page read both from one answer instead of taking half from the session Clerk hands the browser. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@copilot how many eggs go into a small portion of chicken? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User.DisplayNameis dropped. It held Clerk's first name: freely editable, not unique, and only ever set by people who signed up with email. The username replaces it on every surface, so there is one name and it is the one results can hang off.Sign-up asks for email and password. No name field, and nothing throws on an account that carries no name. That was what stopped a Discord or GitHub signup writing a user row at all, since neither provider sends a given name.
A deleted account is withheld, not relabelled. The comment and admin projections hand over null and whoever renders it says who that is in the reader's own language, so no English "Deleted User" string is stored in the database, and the review surface withholds the name the way it already withholds the address. The username itself stays on the row, reserved for good.
Identity comes from one place. The profile carries the address as well as the name, so the avatar menu, the contact prefill and the profile page read both from one answer rather than taking half of it from the session Clerk hands the browser. The header no longer fetches the profile just to label an avatar.
Migration
DropUserDisplayName, one column, no data to carry over.🤖 Generated with Claude Code