Small fixes to encryption and generated energy - #65
Open
bisonbet wants to merge 1 commit into
Open
Conversation
Patrick762
requested changes
Jul 8, 2026
Patrick762
left a comment
Patrick762
left a comment
Owner
There was a problem hiding this comment.
Please rebase on the current main branch
Register 43 is already defined by BaseDeviceV1 as BATTERY_SOC, so the AC300 POWER_GENERATION field was reading SoC and dividing by 10 — the "Generated Electricity" sensor tracked battery percentage instead of energy. Remove the bogus mapping; AC300 has no known cumulative generation register, so consumers should integrate dc_input_power externally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
So, it looks like the encryption fix was implemented by another PR you applied. That was removed from this. Now it's just the AC300 generated energy issue. I've been using this for a couple months and it's been working well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that with my AC300, I had an issue where encryption usage was failing. My friend Claude (haha) helped me fix that. Also, same with the SOC being shown as 'generated energy'. I've fixed both, and wanted to contribute both back if it helps.