Improve Config tab charge UI (colors, Max, alt-charge names)#9975
Closed
mvpizza12-ai wants to merge 1 commit into
Closed
Improve Config tab charge UI (colors, Max, alt-charge names)#9975mvpizza12-ai wants to merge 1 commit into
mvpizza12-ai wants to merge 1 commit into
Conversation
Show Power/Frenzy/Endurance in Int/Dex/Str colors with Max N beside each checkbox, hover tooltips from character constants, and rename to Absorption/Affliction/Brutal when converted. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Pr crashes on load, does not have an example build, does not contain before an after pics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Config's Power / Frenzy / Endurance charge checkboxes are plain text and don't show maximum charges or converted alt-charge names (Absorption / Affliction / Brutal from e.g. Graven's Secret). This makes it harder to see at a glance what the build is using and what each charge does.
Changes:
colorCodes)mainOutput.*ChargesMax)data.characterConstantsConfigTabgains small generic helpers:labelFunc,labelWidthHint, optionalchargeMaxOutput/chargeColorfor checkboxesNo calculation changes — UI / Config presentation only.
Steps taken to verify a working solution:
ConfigOptions.lua+ConfigTab.lua*ChargesConvertTo*)output.PowerChargesMax/FrenzyChargesMax/EnduranceChargesMaxLink to a build that showcases this PR:
Any build; for alt-charge rename, equip an item that grants Absorption/Affliction/Brutal instead of Power/Frenzy/Endurance (e.g. Graven's Secret) and open Config → When In Combat.