Add support for "Unhallowed Rite" Occultist Ascendancy node#9968
Merged
LocalIdentity merged 3 commits intoJul 23, 2026
Conversation
It is now right below "Spirit Charges" which seemed fitting
majochem
marked this pull request as ready for review
July 22, 2026 13:27
LocalIdentity
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This adds support for the new 3.29 Ascendancy Notable "Unhallowed Rite", which provides "Spirit Infusions"
Comments:
Gain Spirit Infusion every **0.5 seconds**rather than"every second", but the mod pattern handles both cases correctly5, but then it would always show up as 50% more damage for channelling spells, which I think is also misleading. Feel free to add the default value if you prefer.Steps taken to verify a working solution:
Combat Buffswith correct numberLimitations:
The actual line for the mod in the data file is
"Gain [SpiritInfusion|Spirit Infusion] every 0.5 seconds while Channelling a Spell", which contains the new keyword highlighting syntax. This PR assumes that the mod line of the nod gets parsed properly. It does not implement the actual sanitizing of that string, as that is something then should probably be handled centrally for all passive node mods.Link to a build that showcases this PR:
After screenshot:
mod parsing:

config option (set to 6, but only 5 apply due to limit):

Combat Buff:

Damage buff effect:

Energy Shield recharge effect:

Cost effect:
