Exit if bad trade leagues JSON#9961
Merged
Merged
Conversation
The next block expects good JSON anyway.
LocalIdentity
approved these changes
Jul 23, 2026
LocalIdentity
approved these changes
Jul 23, 2026
LocalIdentity
merged commit Jul 23, 2026
b097b67
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Code should not continue here, if bad JSON received, since next block expects good JSON.
This also makes clearer the source of an error.
I copy-pasted the same return as the one a little above.
Steps taken to verify a working solution:
This was part of a (discarded) fix I had for pre-OAuth version; now, it's no longer as easy to hit this spot.
But I believe the code flow makes sense.