Skip to content

Port many PoB2 trader features#9934

Merged
LocalIdentity merged 11 commits into
PathOfBuildingCommunity:devfrom
vaisest:trader-stuff
Jul 23, 2026
Merged

Port many PoB2 trader features#9934
LocalIdentity merged 11 commits into
PathOfBuildingCommunity:devfrom
vaisest:trader-stuff

Conversation

@vaisest

@vaisest vaisest commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Fixes #9685

This reworks the mod filtering to use itemClass.GetModSpawnWeight() which means that there should be fewer impossible mods in searches. PoE1 has a lot of mods so I think this is quite useful as the max filter count is much more relevant. This was mostly done by porting existing PoB2 changes which I believe were made by Quickstick and adding my own spawn weight checking code onto it.

I also made implicit mods use the id since it's easily exportable and makes more sense. #9685 was also fixed since it's a tiny pattern change.

This also ports:

Steps taken to verify a working solution:

  • todo

Link to a build that showcases this PR:

Before screenshot:

image ### After screenshot: image

@vaisest
vaisest marked this pull request as draft July 8, 2026 16:43
@vaisest vaisest changed the title Fix unrelated mods polluting trader searches Port many PoB2 trader features Jul 21, 2026
@vaisest
vaisest marked this pull request as ready for review July 22, 2026 19:13
vaisest and others added 3 commits July 23, 2026 21:02
Fix Abyss jewels using the wrong category
Fix import of Watcher's Eye to use selected socket
Avoid emitting false stat groups when no required mods are selected
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jul 23, 2026
@LocalIdentity
LocalIdentity merged commit 62b4f19 into PathOfBuildingCommunity:dev Jul 23, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trade URL not getting recognized

2 participants