Fix impale DPS with zero duration#9862
Merged
LocalIdentity merged 3 commits intoJul 23, 2026
Merged
Conversation
Adds a regression test for zero impale duration and prevents ImpaleDPS from contributing when ImpaleDuration is 0.
Added explanation in breakdown for easier user understanding
Nightblade
reviewed
May 20, 2026
| output.ImpaleDPS = output.impaleStoredHitAvg * ((output.ImpaleModifier or 1) - 1) * output.HitChance / 100 * skillData.dpsMultiplier | ||
| end | ||
| if output.ImpaleDuration <= 0 then | ||
| output.ImpaleDPS = 0 |
Contributor
There was a problem hiding this comment.
Some spaces here where there should be a tab.
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed the indentation.
Fix indentation on line 5878
LocalIdentity
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for zero impale duration and prevents ImpaleDPS from contributing when ImpaleDuration is 0.
Fixes #9499 .
Description of the problem being solved:
Impale DPS was still being calculated and displayed when Impale Duration was 0.
Steps taken to verify a working solution:
busted --lua=luajitLink to a build that showcases this PR:
https://pobb.in/zjvK1N9gCoT8Before screenshot:
After screenshot: