Skip to content

Fix Gemling Frost Wall Ice Crystal life #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaoyaoyang wants to merge 1 commit into
base: dev
Choose a base branch
from
+20 −0
Open

Fix Gemling Frost Wall Ice Crystal life #2386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions spec/System/TestSkills_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,23 @@ describe("TestSkills", function()
assert.are.equals(20, stats["alchemists_boon_cast_speed_granted_+%_during_mana_flask"])
end)

it("applies Advanced Thaumaturgy quality to Frost Wall Ice Crystal life", function()
build.skillsTab:PasteSocketGroup("Frost Wall 20/20 1")
runCallback("OnFrame")

local socketGroup = build.skillsTab.socketGroupList[1]
selectActiveSkillById(socketGroup, "FrostWallPlayer")
local baseLife = build.calcsTab.mainOutput.IceCrystalLife

local advancedThaumaturgy = build.spec.nodes[14429]
advancedThaumaturgy.alloc = true
build.spec.allocNodes[advancedThaumaturgy.id] = advancedThaumaturgy
build.buildFlag = true
runCallback("OnFrame")

assert.are.equals(baseLife * 5, build.calcsTab.mainOutput.IceCrystalLife)
end)

it("describes quality stats from secondary skill stat sets", function()
local grantedEffect = data.skills["ExplosiveSpearPlayer"]
local qualityStat = grantedEffect.qualityStats[1]
Expand Down
3 changes: 3 additions & 0 deletions src/Data/SkillStatMap.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2855,6 +2855,9 @@ return {
["frost_wall_maximum_life"] = {
mod("IceCrystalLifeBase", "BASE", nil),
},
["ice_crystal_maximum_life_+%"] = {
mod("IceCrystalLife", "INC", nil),
},
-- Parry
["base_parry_buff_damage_taken_+%_final_to_apply"] = {
mod("DamageTaken", "MORE", nil, ModFlag.Attack, 0, { type = "GlobalEffect", effectType = "Debuff", effectName = "Parry Debuff", effectCond = "ParryActive" }, { type = "Condition", var = "Effective" }),
Expand Down