Add fullscreen compatibility mode - #125
Draft
PathGao wants to merge 1 commit into
Draft
Conversation
PathGao
marked this pull request as draft
September 1, 2026 02:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an Advanced setting for users who need native macOS / WebKit fullscreen for YouTube and Bilibili. The setting is applied on the next launch because WebKit chooses its fullscreen host while creating the web view.
fs=0and keeps Nifro’s wallpaper presentation.WKPreferences.isElementFullscreenEnabled, and removes every stalefsparameter from the runtime YouTube player URL.WKWebViewdocument.Scope
Does not include the macOS Control Center menu-bar permission repair from #124 or any machine-local Control Center state.
Verification
swift test— 219 tests / 49 suites passedxcodebuild -project Nifro.xcodeproj -scheme Nifro -configuration Release -derivedDataPath .build/pr-derived-2 CODE_SIGNING_ALLOWED=NO buildjq empty Nifro/Localizable.xcstringsgit diff --check