[Nearly done] - Fractional integration with PartyBid - #52
Open
0xfoobar wants to merge 18 commits into
Open
Conversation
anna-carroll
reviewed
Sep 3, 2021
anna-carroll
left a comment
anna-carroll
left a comment
Contributor
There was a problem hiding this comment.
lots of work still to do to clean up console.logs etc, couple of edge cases in the market wrapper to consider
| /** | ||
| * @notice Submit bid to Market contract | ||
| */ | ||
| function bid(uint256 auctionId, uint256 bidAmount) external override { |
Contributor
There was a problem hiding this comment.
missing edge case of placing first bid
Author
There was a problem hiding this comment.
I thought about that - bids might be stuck indefinitely if not enough people join the party to hit the reserve price. Do we want to enable users to optimistically try for a reserve price at the risk of locking up funds indefinitely?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the core pieces are in place, just need to resolve one remaining bug with WETH contract addresses existing.