Skip to content

fix: SSTORE2MetadataProvider indexing - #394

Open
0xble wants to merge 1 commit into
mainfrom
fix/SSTORE2MetadataProvider-indexing
Open

fix: SSTORE2MetadataProvider indexing#394
0xble wants to merge 1 commit into
mainfrom
fix/SSTORE2MetadataProvider-indexing

Conversation

@0xble

@0xble 0xble commented May 20, 2024

Copy link
Copy Markdown
Contributor

Motivation

Solution

@0xble
0xble requested a review from arr00 May 20, 2024 16:45
@height

height Bot commented May 20, 2024

Copy link
Copy Markdown

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@github-actions

Copy link
Copy Markdown

Gas Report:
Accept Proposal: 31749
Create party custom metadata: 726170
Create party vanilla: 296856
Contribute to ETH party: 204946
Batch contribute two memberships to ETH party: 278336
Create proposal transfer eth: 141169
Execute proposal transfer eth: 123058
Create proposal distribute: 139523
Execute proposal distribute: 232549
Claim distribution: 74905

@codecov-commenter

codecov-commenter commented May 20, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.85%. Comparing base (8522dba) to head (a7a0cb0).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
contracts/renderers/SSTORE2MetadataProvider.sol 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   70.87%   70.85%   -0.03%     
==========================================
  Files          71       71              
  Lines        3114     3115       +1     
  Branches      673      674       +1     
==========================================
  Hits         2207     2207              
  Misses        702      702              
- Partials      205      206       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants