feat: add new distributor - #377
Open
0xble wants to merge 15 commits into
Open
Conversation
|
This pull request has been linked to 1 task:
|
0xble
marked this pull request as draft
February 13, 2024 19:55
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 66.82% 67.44% +0.61%
==========================================
Files 70 71 +1
Lines 2963 3010 +47
Branches 647 658 +11
==========================================
+ Hits 1980 2030 +50
+ Misses 783 779 -4
- Partials 200 201 +1 ☔ View full report in Codecov by Sentry. |
|
Gas Report: |
0xble
commented
Feb 13, 2024
Closed
arr00
reviewed
Feb 16, 2024
arr00
left a comment
arr00
left a comment
Contributor
There was a problem hiding this comment.
Coming along well. Some thoughts so far.
0xble
commented
Feb 16, 2024
Co-authored-by: Brian Le <brian@brianle.xyz>
0xble
marked this pull request as ready for review
February 16, 2024 19:35
arr00
reviewed
Feb 16, 2024
arr00
left a comment
arr00
left a comment
Contributor
There was a problem hiding this comment.
Looks good for the most part. A few comments
arr00
reviewed
Feb 16, 2024
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
arr00
approved these changes
Feb 28, 2024
| // Token address used to indicate ETH. | ||
| IERC20 private constant ETH_ADDRESS = IERC20(0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE); | ||
|
|
||
| function distribute( |
Contributor
There was a problem hiding this comment.
Would like detailed natspec here. It's a pretty advanced function. Otherwise PR looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Link T-4299