Skip to content

Ensure contribution router target is a contract - #374

Open
arr00 wants to merge 2 commits into
mainfrom
chore/validate-contribution-router-target
Open

Ensure contribution router target is a contract#374
arr00 wants to merge 2 commits into
mainfrom
chore/validate-contribution-router-target

Conversation

@arr00

@arr00 arr00 commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Link T-4348

@height

height Bot commented Feb 7, 2024

Copy link
Copy Markdown

This pull request has been linked to 1 task:

💡Tip: Add "Close T-4348" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@arr00
arr00 requested a review from 0xble February 7, 2024 14:36
@github-actions

github-actions Bot commented Feb 7, 2024

Copy link
Copy Markdown

Gas Report:
Accept Proposal: 31749
Create party custom metadata: 726170
Create party vanilla: 296856
Contribute to ETH party: 204946
Batch contribute two memberships to ETH party: 278352
Create proposal transfer eth: 141169
Execute proposal transfer eth: 123058
Create proposal distribute: 139523
Execute proposal distribute: 227375
Claim distribution: 71963

@codecov-commenter

codecov-commenter commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8245386) 66.70% compared to head (6bbc004) 66.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   66.70%   66.74%   +0.04%     
==========================================
  Files          69       69              
  Lines        2946     2950       +4     
  Branches      644      645       +1     
==========================================
+ Hits         1965     1969       +4     
  Misses        783      783              
  Partials      198      198              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants