feat: rage quit - #219
Open
addyxvii wants to merge 25 commits into
Open
Conversation
|
Contributor
|
Thanks for this! I'll review this tomorrow |
0xble
suggested changes
Feb 15, 2023
0xble
reviewed
Mar 23, 2023
0xble
reviewed
Mar 23, 2023
0xble
left a comment
Contributor
There was a problem hiding this comment.
Nice!
Just run yarn lint and commit changes to fix formatting. 😊
0xble
approved these changes
Apr 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This feature gives a contributor to a party the ability to rage quit(withdraw 100% of their contribution) before a crowdfund is finalized.
Solution
A
rageQuitfunction has been created that increases a new variabletotalContributionsWithdrawn, and removes the_contributionsByContributormapping for the user who quit. The function also returns the quitting user's total contribution from the crowdfund.previousTotalContributionsWithdrawnhas been added to theContributionstruct for proper accounting in the_getFinalContributionfunction