Spank prolog alloc - #21
Open
nchaimov wants to merge 9 commits into
Open
Conversation
We only need workarounds for delayed prolog in the default mode. If PrologFlags=Alloc is set in slurm.conf, don't use the workarounds and instead launch Spindle on all nodes in the prolog.
- Fix warning about unchecked pipe, chdir - Fix write from wrong string in dropPrivilegeAndRun - Fix useless check that substituted NULL for NULL
- Fix double free of hostlist in case of error - Fix grandchild_fork exit check - Fix leaks in get_num_hosts_step, dropPrivilegeAndRun - Fix allocation size in isBEProc - Fix outdated fillInArgs args in SPLIT_CALLBACK_MODE
- Check exit socket path length - Verify that correct exit message received - Handle forwarded environment in exit
- Check handleStart failure in addition to prepApp - Only use step ID env var in job script context - Check realize failure in fillInArgs
- Set current_slurm first so we can look up job control env vars - Don't leak orig_commpath if realize created a new one - Use env var in commpath in Slurm plugin container to test that branch of realize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dummy PR to force CI to run