Schema validation sweep - #50
Merged
Merged
Conversation
The suite validated one hand-written document, which reaches the cases its author had in mind. The snapshots are what the conversions actually produce, so sweeping them reaches the markup nobody thought to construct. Fourteen of the 314 failed, across two defects: - The header and footer references open the sectPr sequence, ahead of the page setup EnsureSectionProperties has already put there. They were appended, so they landed behind it. - w:ind was appended to a pPr that already carried contextualSpacing, where the schema puts ind first. Reading that second one turned up more that no snapshot covers: css arrives in the order it is written, so ApplyParagraphFormat was emitting spacing, ind, jc, shd, bidi, textDirection, pBdr where CT_PPrBase declares pBdr, shd, bidi, spacing, ind, jc, textDirection. Every pPr child now goes in at its declared position rather than at the end, and ParagraphPropertiesFollowSchemaOrder pins the whole sequence, since a snapshot only covers the combinations some test happened to write. Word repairs all of this on open, which is why none of it had surfaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.