Skip to content

[WIP] Particle flow reconstruction algorithms for IDEA option2 detector - #33

Draft
SanghyunKo wants to merge 2 commits into
PandoraPFAOrg:masterfrom
SanghyunKo:dev_ideao2_pflow
Draft

[WIP] Particle flow reconstruction algorithms for IDEA option2 detector#33
SanghyunKo wants to merge 2 commits into
PandoraPFAOrg:masterfrom
SanghyunKo:dev_ideao2_pflow

Conversation

@SanghyunKo

Copy link
Copy Markdown
Contributor

Pandora algorithms for the particle flow reconstruction with the IDEA option 2 detector. This is designed to work on ECAL clusters built by HEP-FCC/k4RecCalorimeter#271 via edm4hep::Cluster to pandora::Cluster conversion using key4hep/k4GaudiPandora#26. HCAL clusters are built within the pandora, seeded by the input ECAL clusters. There are also 3 algorithms that use ML via ONNX inference (photon ID, satellite cluster merging, and photon energy regression).

A presentation related to the physics contents will take place in https://indico.cern.ch/event/1707528/#9-pandora-for-idea-updates

Expect a few more changes before ready-to-review (I currently retrieve HCAL dimensions via input configuration, but ideally this should be done via the Pandora geometry tool). Microscopic review can be done later, but one can already have a look at the macroscopic design, e.g., overall structure, etc.

@SanghyunKo

Copy link
Copy Markdown
Contributor Author

A note on the test - I'm not sure whether we can have any type of test in LCContent. Nevertheless I plan to create a follow-up PR in k4GaudiPandora and prepare a test workflow there.

@jmcarcell

Copy link
Copy Markdown
Collaborator

Did you check if none of the existing algorithms can do what the new ones do? There are a lot of completely new ones. And for the one algorithms that changes the downside is that it has to be validated, for example, on the CLD reconstruction. In addition it adds the onnxruntime dependency. I wonder if future changes are going in the direction of not modifying the existing ones, if it would be better to create another repository with Pandora algorithms.

@SanghyunKo

Copy link
Copy Markdown
Contributor Author

I did try to reuse the existing ones as much as possible - this PR obviously includes only the new ones (or modified/extended ones) while I have also other LCContent algorithms that I reuse in the full reconstruction chain. Hence, I personally opt to have everything in LCContent, but we can discuss the strategy in one of the key4hep meetings.

Perhaps we can adopt the LArTPC approach, i.e. keep LCContent without ML dependencies and create another repo dedicated to algorithms with ML use cases.

@Zehvogel

Copy link
Copy Markdown

I cannot estimate yet how much discussion there will be here in total, but you might want to consider splitting the changes to the IsolatedHitMergingAlgorithm from this into a separate PR. :)
Regarding ONNX, I guess it is fine if it (and the algorithms relying on it) are toggleable in the build.

@SanghyunKo

SanghyunKo commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Seems like the build test is using PandoraSDK v03.04.01, where this PR requires at least v04-00-01.

@jmcarcell

Copy link
Copy Markdown
Collaborator

Seems like the build test is using PandoraSDK v03.04.01, where this PR requires at least v04-00-01.

Please update the requirements wherever find_package(PandoraSDK REQUIRED <VERSION>) (if version is not there then it should be added). Now, in the Key4hep stack in LCG (alma9, ubuntu26 in CI, PandoraSDK has the latest version, 5.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants