[draft]: DL Slicing + 3D DL Vertexing - #296
Draft
CrossR wants to merge 108 commits into
Draft
Conversation
Still need to test though.
Previously, we were adding ~5x more edges than required, exploding the RAM.
May help clear up some plots. My guesstimate is that the old plots look artificially worse as we plot against the biggest...when another was okay. If that is the case, we should be able to see that in these new plots.
Can refactor later into generic with custom scoring func if useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't supposed to be a production-level PR, so its a bit of a mess as its directly from my development branch, without any squashing or tidying.
There is interest from the ND side to get some form of review going, so the code itself can be looked over etc. This can start that process, and when I'm back from PTO I intend to fix any comments, and also do a removal of unnecessary code and also squash the history considerably.
...Since this is a raw development branch it also contains a few unrelated bits to this work, so I'd basically say if its not in a "Slicing" folder...it can be ignored. It was likely me testing stuff for the ND (i.e. speeding things up in helpers, altering the master workflow to aide the RAM usage we see there etc).
Of most interest will be:
larpandoradlcontent/LArSlicing/DlSlicingAlgorithm.cc|h- The actual DL Slicing code.larpandoradlcontent/LArSlicing/DlVertexingThreeDAlgorithm.cc|h- Actual 3D DL Vertexing code.larpandoradlcontent/LArSlicing/HoughFinder.cc|h- Hough transform used in both of the above.larpandoradlcontent/LArSlicing/KnnKDTree.cc|h- Not actually used now...may remove. 3D KDTree that was previously used for making the graphs. Candidate for deletion.larpandoradlcontent/LArSlicing/BasicVertexingMetrics.cc|h- Just vertexing metrics for development...will be removed so can ignore.