Skip to content

Add PR checks and stricter typechecking#2

Merged
PabloZaiden merged 1 commit into
mainfrom
chat-build-and-test-600bc642
May 11, 2026
Merged

Add PR checks and stricter typechecking#2
PabloZaiden merged 1 commit into
mainfrom
chat-build-and-test-600bc642

Conversation

@PabloZaiden
Copy link
Copy Markdown
Owner

Summary

  • add a pull_request workflow that installs dependencies, typechecks, and runs tests
  • enable stricter TypeScript checks used by downstream consumers
  • remove an unused updater variable caught by noUnusedLocals

Validation

  • bun run build
  • bun test

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 11, 2026 12:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens repository quality gates by enabling stricter TypeScript compiler checks and adding a pull request CI workflow to automatically typecheck and run tests on PRs.

Changes:

  • Enabled noUnusedLocals, noUnusedParameters, and noPropertyAccessFromIndexSignature in tsconfig.json.
  • Removed an unused local (tempCreated) in the updater flow to satisfy the stricter compiler settings.
  • Added a pull_request GitHub Actions workflow to run bun run build (typecheck) and bun test.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
tsconfig.json Turns on additional TypeScript strictness flags to catch unused code and unsafe property access.
src/update.ts Removes an unused variable to keep the updater implementation clean under stricter typechecking.
.github/workflows/pr-checks.yml Adds PR CI to install dependencies, typecheck, and run tests using Bun.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PabloZaiden PabloZaiden merged commit 49f19a4 into main May 11, 2026
5 checks passed
@PabloZaiden PabloZaiden deleted the chat-build-and-test-600bc642 branch May 11, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants