Add PR checks and stricter typechecking#2
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR strengthens repository quality gates by enabling stricter TypeScript compiler checks and adding a pull request CI workflow to automatically typecheck and run tests on PRs.
Changes:
- Enabled
noUnusedLocals,noUnusedParameters, andnoPropertyAccessFromIndexSignatureintsconfig.json. - Removed an unused local (
tempCreated) in the updater flow to satisfy the stricter compiler settings. - Added a
pull_requestGitHub Actions workflow to runbun run build(typecheck) andbun test.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tsconfig.json |
Turns on additional TypeScript strictness flags to catch unused code and unsafe property access. |
src/update.ts |
Removes an unused variable to keep the updater implementation clean under stricter typechecking. |
.github/workflows/pr-checks.yml |
Adds PR CI to install dependencies, typecheck, and run tests using Bun. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation