Updated hummingbird.xacro compatibility with multirotor_base - #7
Open
wilselby wants to merge 2 commits into
Open
Updated hummingbird.xacro compatibility with multirotor_base#7wilselby wants to merge 2 commits into
wilselby wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hummingbird.xacro was missing mesh_file and mesh_scale arguments for the body. Also missing mesh and mesh_scale arguments for each rotor. Added arguments to be compatible with multirotor_base.xacro
Also edited the odometry plugin to remove adding the namespace to the link name. This allows users to be more flexible with the link_name input and can add the namespace in the .xacro file when calling this plugin.