Skip to content

Fix macOS GUI build to bundle customtkinter and set installer title#80

Merged
RenanGBarreto merged 6 commits into
mainfrom
feat/gui-review-v2
Jul 1, 2026
Merged

Fix macOS GUI build to bundle customtkinter and set installer title#80
RenanGBarreto merged 6 commits into
mainfrom
feat/gui-review-v2

Conversation

@RenanGBarreto

@RenanGBarreto RenanGBarreto commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Fix macOS GUI build to bundle customtkinter and show proper installer title

🤔 Why?

  • The macOS package produced by CI missed GUI runtime dependencies (notably customtkinter), causing the app to crash on startup with ModuleNotFoundError.
  • The macOS Installer window also lacked a friendly product title, making the installed app appear less polished.

🔧 What changed

  • Ensure GUI runtime deps (customtkinter, Pillow) are installed into the uvx Python used in CI so PyInstaller can analyze and bundle them.
  • Add a PyInstaller hook (pyinstaller-hooks/hook-customtkinter.py) to reliably collect customtkinter submodules and data files.
  • Update the macOS packaging step to pass a human-friendly installer title to productbuild so the Installer GUI shows "MkPFS ".

🧪 How to test

  • Run the CI mac build or the mac packaging steps locally.

  • Install the produced .pkg and then run:

    /Applications/MkPFS.app/Contents/MacOS/MkPFS

    Confirm the GUI launches without ModuleNotFoundError and that the Installer window displays the product title/version.

💬 Notes for non-technical readers

  • This fixes crashes on macOS caused by a missing GUI dependency and makes the installer display a proper product name. The application code and user data are unchanged.

@github-code-quality

github-code-quality Bot commented Jun 29, 2026

Copy link
Copy Markdown

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall coverage remains at 75%, unchanged from the branch.


Updated June 29, 2026 14:29 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@RenanGBarreto RenanGBarreto added the bug Something isn't working label Jun 29, 2026
@RenanGBarreto RenanGBarreto changed the title ci(mac): install GUI deps into uvx python and add PyInstaller hook for customtkinter; set installer title Fix macOS GUI build to bundle customtkinter and set installer title Jun 29, 2026
@RenanGBarreto RenanGBarreto enabled auto-merge (squash) July 1, 2026 12:42
@RenanGBarreto RenanGBarreto disabled auto-merge July 1, 2026 12:42
@RenanGBarreto RenanGBarreto merged commit 6b1d53d into main Jul 1, 2026
12 checks passed
@RenanGBarreto RenanGBarreto deleted the feat/gui-review-v2 branch July 1, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant